Add Tenor feature flag through selected build type #4
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This Pull Request makes possible to enable or disable the Tenor GIF picker availability accordingly to the selected WordPress build type. This change adds to the issue 11456.
The solution proposes the following implementation:
The
BuildConfig
now receive the declaration of the booleanTENOR_AVAILABLE
field directly from thebuild.gradle
.The button availability to select the Tenor GIF picker follows the
TENOR_AVAILABLE
value, if the value is false, the button doesn't get configured and should never appear on the screen.The
TENOR_AVAILABLE
is set astrue
for the Wasabi and Zalpha builds andfalse
for the Vanilla build.Testing from the Post Editor
with Wasabi and Zalpha build
Switch to classic editor
Choose from Tenor
option is availableselection
,preview
andadd
are all working as expectedwith Vanilla build
Switch to classic editor
Choose from Tenor
option isn't thereTesting from the Media Browser
with Wasabi and Zalpha build
Choose from Tenor
option is availableselection
,preview
andadd
are all working as expectedwith Vanilla build
Choose from Tenor
option isn't therePR submission checklist
RELEASE-NOTES.txt
if necessary.